ITS: restore previous UPC iteration#15289
Merged
shahor02 merged 4 commits intoAliceO2Group:devfrom Apr 20, 2026
Merged
Conversation
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
f3sch
requested review from
a team,
davidrohr,
fprino,
mconcas,
mcoquet642 and
shahor02
as code owners
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
shahor02
reviewed
Apr 19, 2026
| float timeTracklet{0.f}, timeSelection{0.f}, timeVertexing{0.f}, timeInit{0.f}; | ||
| try { | ||
| for (int iteration = 0; iteration < std::min(mVertParams[0].nIterations, (int)mVertParams.size()); ++iteration) { | ||
| for (int iteration = 0; iteration < (int)mVertParams.size(); ++iteration) { |
Collaborator
There was a problem hiding this comment.
Since the mVertParams.size is hardcoded to 2, this means that we will always run 2 iterations?
And since the actual job done by the 2nd iteration is triggered by nvertices(1st iteration) < vertPerRofThreshold, we have no way to disable it, even effectively? Do I miss something?
Collaborator
Author
There was a problem hiding this comment.
No, by default there is only one iteration run, since the ITSVertexerParam.nIterations=1 by default, which triggers capping the mVertParams to only 1. In o2dpg for Pb-Pb we specficially set it nIterations=2.
Collaborator
|
Error while checking build/O2/fullCI_slc9 for dd8f6fe at 2026-04-19 17:04: Full log here. |
shahor02
approved these changes
Apr 19, 2026
Collaborator
|
Tested locally. Merging as it fixes the ITS reco crashing in the empty TFs. |
f3sch
added a commit
to f3sch/O2DPG
that referenced
this pull request
Apr 20, 2026
Removed unused vertexing parameters from configuration. Needed with merge of AliceO2Group/AliceO2#15289
shahor02
pushed a commit
to AliceO2Group/O2DPG
that referenced
this pull request
Apr 20, 2026
Removed unused vertexing parameters from configuration. Needed with merge of AliceO2Group/AliceO2#15289
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I simplified some parameters into a single one (1:1). Also this correctly 'restores' how the UPC iteration is done.